netdev - Re: [Suggestion] drivers/isdn: about the loop after call isdn_tty_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Feb 2013 11:00:44 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Chen Gang <gang.chen@...anux.com>, Jiri Kosina <jkosina@...e.cz>,
	isdn@...ux-pingi.de
CC:	Greg KH <gregkh@...uxfoundation.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [Suggestion] drivers/isdn: about the loop after call isdn_tty_send_msg

On 02/27/2013 10:32 AM, Chen Gang wrote:
> Hello Maintainers:
> 
>   do we need break out of the loop after call isdn_tty_send_msg ?
>     p is not increased after finish calling isdn_tty_send_msg.
>     and then will loop back to process the p again.
> 
>   do we intend to scan again the string which appended "+M..." ?

Nope, we should break the for loop because isdn_tty_send_msg is intended
to eat the rest of the string. Evidently nobody tested this path yet.

>   we also assume "+M..." is a NUL terminated string, is it OK ? (it seems ok)

Yes, p should be NUL-terminated.

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html