netdev - RE: [PATCH 0/4] sctp: fix association hangs due to reassembly/ordering logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D64EC45690EF85409BA6C4730E0162244310EF1F@G4W3231.americas.hpqcorp.net>
Date:	Wed, 27 Feb 2013 18:55:36 +0000
From:	"Roberts, Lee A." <lee.roberts@...com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH 0/4] sctp: fix association hangs due to
 reassembly/ordering logic

I missed the change in the calling sequence for sctp_ulpq_partial_delivery()
when porting the changes forward from 3.2.x.  An updated patch has been sent.

                                             - Lee Roberts

-----Original Message-----
From: David Miller [mailto:davem@...emloft.net] 
Sent: Wednesday, February 27, 2013 11:10 AM
To: Roberts, Lee A.
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH 0/4] sctp: fix association hangs due to reassembly/ordering logic
Importance: High

From: "Lee A. Roberts" <lee.roberts@...com>
Date: Tue, 26 Feb 2013 07:36:12 -0700

> From: "Lee A. Roberts" <lee.roberts@...com>
> 
> This series of patches resolves several SCTP association hangs observed during
> SCTP stress testing.  Observable symptoms include communications hangs with
> data being held in the association reassembly and/or lobby (ordering) queues.
> Close examination of reassembly/ordering queues may show either duplicated
> or missing packets.
> 
> Lee A. Roberts (4):
>   sctp: fix association hangs due to off-by-one errors in
>     sctp_tsnmap_grow()
>   sctp: fix association hangs due to reneging packets below the
>     cumulative TSN ACK point
>   sctp: fix association hangs due to errors when reneging events from
>     the ordering queue
>   sctp: fix association hangs due to partial delivery errors

Appying these patches breaks the build:

net/sctp/ulpqueue.c: In function ‘sctp_ulpq_renege’:
net/sctp/ulpqueue.c:1115:4: warning: passing argument 2 of ‘sctp_ulpq_partial_delivery’ makes integer from pointer without a cast [enabled by default]
net/sctp/ulpqueue.c:1038:6: note: expected ‘gfp_t’ but argument is of type ‘struct sctp_chunk *’
net/sctp/ulpqueue.c:1115:4: error: too many arguments to function ‘sctp_ulpq_partial_delivery’
net/sctp/ulpqueue.c:1038:6: note: declared here
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html