netdev - RE: [PATCH] net/rds: using strlcpy instead of strncpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B716D@saturn3.aculab.com>
Date:	Thu, 28 Feb 2013 09:36:48 -0000
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Chen Gang" <gang.chen@...anux.com>,
	<venkat.x.venkatsubra@...cle.com>,
	"David Miller" <davem@...emloft.net>, <rds-devel@....oracle.com>,
	"netdev" <netdev@...r.kernel.org>
Subject: RE: [PATCH] net/rds: using strlcpy instead of strncpy

>   when src strlen is sizeof(ctr.name) - 1, the dest str is not '\0' end.
>   better use strlcpy instead.
> 
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>  net/rds/stats.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/rds/stats.c b/net/rds/stats.c
> index 7be790d..b9ac1df 100644
> --- a/net/rds/stats.c
> +++ b/net/rds/stats.c
> @@ -86,7 +86,7 @@ void rds_stats_info_copy(struct rds_info_iterator *iter,
> 
>  	for (i = 0; i < nr; i++) {
>  		BUG_ON(strlen(names[i]) >= sizeof(ctr.name));
> -		strncpy(ctr.name, names[i], sizeof(ctr.name) - 1);
> +		strlcpy(ctr.name, names[i], sizeof(ctr.name));
>  		ctr.value = values[i];
> 

If the target buffer ends up being copied to userspace that
might lead to random kernel memory being leaked.

	David




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html