netdev - RE: [RFC PATCH 3/3] mlx4: Use default fdb handlers when not multifunction.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <0EE9A1CDC8D6434DB00095CD7DB87346219AC704@MTLDAG02.mtl.com>
Date:	Thu, 28 Feb 2013 12:32:23 +0000
From:	Yan Burman <yanb@...lanox.com>
To:	"john.r.fastabend@...el.com" <john.r.fastabend@...el.com>,
	"vyasevic@...hat.com" <vyasevic@...hat.com>
CC:	Or Gerlitz <ogerlitz@...lanox.com>,
	Amir Vadai <amirv@...lanox.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [RFC PATCH 3/3] mlx4: Use default fdb handlers when not
 multifunction.



> From: John Fastabend <john.r.fastabend@...el.com>
> Date: Thu, Feb 28, 2013 at 6:27 AM
> Subject: Re: [RFC PATCH 3/3] mlx4: Use default fdb handlers when not
> multifunction.
> To: Vlad Yasevich <vyasevic@...hat.com>, Amir Vadai <amirv@...lanox.com>
> Cc: netdev@...r.kernel.org, davem@...emloft.net
> 
> 
> On 2/27/2013 9:46 AM, Vlad Yasevich wrote:
> >
> > Allow the use of ndo_dflt_fdb_<add|del|dump> when the adapter is not
> > configured with virtual functins (!mlx4_is_mfunc()) This allows proper
> > IFF_UNICAST_FLT support and allows for additional handling by the
> > driver if needed.
> >
> > CC: Amir Vadai <amirv@...lanox.com>
> > Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>
> > ---
> >   drivers/net/ethernet/mellanox/mlx4/en_netdev.c |   12 +++---------
> >   1 files changed, 3 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> > b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> > index 5385474..5732025 100644
> > --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> > +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> > @@ -1934,7 +1934,7 @@ static int mlx4_en_fdb_add(struct ndmsg *ndm,
> > struct nlattr *tb[],
> 
> 
> Amir are the default ops good enough here?
> 

The default ops can be used instead of mlx4 fdb_add, fdb_delete, and fdb_dump.

Yan

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html