netdev - Re: [patch] sctp: use the passed in gfp flags instead GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130301143517.GA1523@hmsreliant.think-freely.org>
Date:	Fri, 1 Mar 2013 09:35:17 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Vlad Yasevich <vyasevich@...il.com>,
	Sridhar Samudrala <sri@...ibm.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-sctp@...r.kernel.org, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] sctp: use the passed in gfp flags instead GFP_KERNEL

On Fri, Mar 01, 2013 at 08:27:43AM +0300, Dan Carpenter wrote:
> This patch doesn't change how the code works because in the current
> kernel gfp is always GFP_KERNEL.  But gfp was obviously intended
> instead of GFP_KERNEL.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/net/sctp/endpointola.c b/net/sctp/endpointola.c
> index 2b3ef03..12ed45d 100644
> --- a/net/sctp/endpointola.c
> +++ b/net/sctp/endpointola.c
> @@ -155,7 +155,7 @@ static struct sctp_endpoint *sctp_endpoint_init(struct sctp_endpoint *ep,
>  
>  	/* SCTP-AUTH extensions*/
>  	INIT_LIST_HEAD(&ep->endpoint_shared_keys);
> -	null_key = sctp_auth_shkey_create(0, GFP_KERNEL);
> +	null_key = sctp_auth_shkey_create(0, gfp);
>  	if (!null_key)
>  		goto nomem;
>  
> 
Acked-by: Neil Horman <nhorman@...driver.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html