netdev - Re: [PATCH 1/1 net-next] fec: net: put tx to napi poll function to fix dead lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130228.220651.893690287619309792.davem@davemloft.net>
Date:	Thu, 28 Feb 2013 22:06:51 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	lznuaa@...il.com
Cc:	Frank.Li@...escale.com, shawn.guo@...aro.org, B38611@...escale.com,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	s.hauer@...gutronix.de
Subject: Re: [PATCH 1/1 net-next] fec: net: put tx to napi poll function to
 fix dead lock

From: Frank Li <lznuaa@...il.com>
Date: Fri, 1 Mar 2013 11:05:57 +0800

> 2013/3/1 David Miller <davem@...emloft.net>:
>> From: Frank Li <Frank.Li@...escale.com>
>> Date: Thu, 28 Feb 2013 11:44:20 +0800
>>
>>> +     int tx_pkts = fec_enet_tx(ndev);
>>> +
>>> +     if (tx_pkts)
>>> +             return budget;
>>
>> This isn't right, you don't want to finish the NAPI poll because
>> TX work was done.
>>
>> Ignore the TX work for poll completion purposes, see
>> drivers/net/ethernet/broadcom/tg3.c:tg3_poll_work() for
>> example.
> 
> I read tg3.c code. If I understand correct,
> just need remove below line
> 
>     if (tx_pkts)
>              return budget;
> 
> Is it ture?

Yes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html