netdev - Re: tg3: regression of netdev stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1362152836.6212.27.camel@LTIRV-MCHAN1.corp.ad.broadcom.com>
Date:	Fri, 1 Mar 2013 07:47:16 -0800
From:	"Michael Chan" <mchan@...adcom.com>
To:	"OGAWA Hirofumi" <hirofumi@...l.parknet.co.jp>
cc:	nsujir@...adcom.com, davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: tg3: regression of netdev stats

On Fri, 2013-03-01 at 22:21 +0900, OGAWA Hirofumi wrote: 
> Hi,
> 
> f4a46d1f46a8fece34edd2023e054072b02e110d (tg3: Prevent spurious tx
> timeout by setting carrier off before tx disable.) seems to add the bug.
> 
> On 3.8.1 (I didn't use 3.7.x series), "ifconfig" commands doesn't show
> any stats, i.e. all stats are zero.

No stats on an active device transmitting and receiving packets?  I
don't seem to see the same problem, but we'll look into this further.
Thanks.

> And bisect points the above commit.
> In fact, reverting the above patch fixes the regression of netdev stats.
> 
> This patch looks like strange, and I'm not sure what this want to do.
> Any ideas?

Every time we reset the device (ethtool, MTU change, etc), we need to
turn off all the tx queues before resetting.  As soon as we turn off
these queues, if we don't turn off carrier, a tx timeout may be
triggered if it's been more than 5 seconds since the last transmit on
any of the tx queues.  These tx timeouts cause unnecessary concern to
the user.

> 
> Well, anyway, this is bug report.
> 
> Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html