netdev - Re: [PATCH net-next] ipv4: correct dropwatch false positive in ip_local_deliver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130301171225.GB1523@hmsreliant.think-freely.org>
Date:	Fri, 1 Mar 2013 12:12:25 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	William Reich <reich@...icom.com>
Subject: Re: [PATCH net-next] ipv4: correct dropwatch false positive in
 ip_local_deliver_finish

On Fri, Mar 01, 2013 at 08:38:32AM -0800, Eric Dumazet wrote:
> On Fri, 2013-03-01 at 11:18 -0500, Neil Horman wrote:
> > I had a report recently of a user trying to use dropwatch to localise some frame
> > loss, and they were getting false positives.  Turned out they were using a user
> > space SCTP stack that used raw sockets to grab frames.  When we don't have a
> > registered protocol for a given packet, we record it as a drop, even if a raw
> > socket receieves the frame.  We should only record the drop in the event a raw
> > socket doesnt exist to receive the frames
> > 
> > Tested by the reported successfully
> > 
> > Signed-off-by: Neil Horman <nhorman@...driver.com>
> > Reported-by: William Reich <reich@...icom.com>
> > Tested-by: William Reich <reich@...icom.com>
> > CC: "David S. Miller" <davem@...emloft.net>
> > CC: William Reich <reich@...icom.com>
> > ---
> >  net/ipv4/ip_input.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> Hmm, could you perhaps do the similar fix for IPv6 in the same patch ?
> 
> Thanks !
> 
Sure, give me a moment, and I'll respin it.
Neil

> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html