netdev - Re: [PATCH v2 1/1 net-next] fec: net: put tx to napi poll function to fix dead lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130301.155859.2106303756469493825.davem@davemloft.net>
Date:	Fri, 01 Mar 2013 15:58:59 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	Frank.Li@...escale.com
Cc:	lznuaa@...il.com, shawn.guo@...aro.org, B38611@...escale.com,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	s.hauer@...gutronix.de
Subject: Re: [PATCH v2 1/1 net-next] fec: net: put tx to napi poll function
 to fix dead lock

From: Frank Li <Frank.Li@...escale.com>
Date: Fri, 1 Mar 2013 11:37:14 +0800

> @@ -566,27 +554,47 @@ fec_timeout(struct net_device *ndev)
>  	netif_wake_queue(ndev);
>  }
>  
> -static void
> +static int
>  fec_enet_tx(struct net_device *ndev)

The return value of this function is never tested, get rid of it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html