netdev - Re: [PATCH v2 net-next] ipv[4|6]: correct dropwatch false positive in local_deliver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130301210545.GD1523@hmsreliant.think-freely.org>
Date:	Fri, 1 Mar 2013 16:05:45 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, reich@...icom.com
Subject: Re: [PATCH v2 net-next] ipv[4|6]: correct dropwatch false positive
 in local_deliver_finish

On Fri, Mar 01, 2013 at 03:57:09PM -0500, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Fri, 01 Mar 2013 09:56:44 -0800
> 
> > On Fri, 2013-03-01 at 12:44 -0500, Neil Horman wrote:
> >> I had a report recently of a user trying to use dropwatch to localise some frame
> >> loss, and they were getting false positives.  Turned out they were using a user
> >> space SCTP stack that used raw sockets to grab frames.  When we don't have a
> >> registered protocol for a given packet, we record it as a drop, even if a raw
> >> socket receieves the frame.  We should only record the drop in the event a raw
> >> socket doesnt exist to receive the frames
> >> 
> >> Tested by the reported successfully
> >> 
> >> Signed-off-by: Neil Horman <nhorman@...driver.com>
> >> Reported-by: William Reich <reich@...icom.com>
> >> Tested-by: William Reich <reich@...icom.com>
> >> CC: "David S. Miller" <davem@...emloft.net>
> >> CC: William Reich <reich@...icom.com>
> >> CC: eric.dumazet@...il.com
> >> ---
> >>  net/ipv4/ip_input.c  | 6 ++++--
> >>  net/ipv6/ip6_input.c | 6 ++++--
> >>  2 files changed, 8 insertions(+), 4 deletions(-)
> > 
> > Thanks !
> > 
> > Acked-by: Eric Dumazet <edumazet@...gle.com>
> 
> This seems like a reasonable bug fix so I'm going to apply this to
> 'net', thanks everyone.
> 
Copy that, thanks Dave!
Neil

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html