netdev - Re: [PATCH] filter: fix sparse warning for bpf_internal_load_pointer_neg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1362362923.15793.84.camel@edumazet-glaptop>
Date:	Sun, 03 Mar 2013 18:08:43 -0800
From:	Eric Dumazet <erdnetdev@...il.com>
To:	Claudiu Ghioc <claudiughioc@...il.com>
Cc:	davem@...emloft.net, edumazet@...gle.com, dborkman@...hat.com,
	jpirko@...hat.com, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Claudiu Ghioc <claudiu.ghioc@...il.com>
Subject: Re: [PATCH] filter: fix sparse warning for
 bpf_internal_load_pointer_neg_helper

On Mon, 2013-03-04 at 01:30 +0200, Claudiu Ghioc wrote:
> Removed the following sparse warning:
> *   net/core/filter.c:48:6: warning: symbol
>     'bpf_internal_load_pointer_neg_helper' was
>     not declared. Should it be static?
> 
> Signed-off-by: Claudiu Ghioc <claudiu.ghioc@...il.com>
> ---
>  net/core/filter.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 2e20b55..f6c907c 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -45,7 +45,7 @@
>   *
>   * Exported for the bpf jit load helper.
>   */
> -void *bpf_internal_load_pointer_neg_helper(const struct sk_buff *skb, int k, unsigned int size)
> +static void *bpf_internal_load_pointer_neg_helper(const struct sk_buff *skb, int k, unsigned int size)
>  {
>  	u8 *ptr = NULL;
>  

Hmm, have you read the comment ?

Also :


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html