netdev - Re: [PATCH -v3 17/23] net/sunrpc: rename random32() to prandom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FA345DA4F4AE44899BD2B03EEEC2FA9286AF0DB@sacexcmbx05-prd.hq.netapp.com>
Date:	Mon, 4 Mar 2013 22:44:13 +0000
From:	"Myklebust, Trond" <Trond.Myklebust@...app.com>
To:	Akinobu Mita <akinobu.mita@...il.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"J. Bruce Fields" <bfields@...ldses.org>,
	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>
Subject: Re: [PATCH -v3 17/23] net/sunrpc: rename random32() to prandom_u32()

On Mon, 2013-03-04 at 21:58 +0900, Akinobu Mita wrote:
> Use more preferable function name which implies using a pseudo-random
> number generator.
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
> Cc: "J. Bruce Fields" <bfields@...ldses.org>
> Cc: Trond Myklebust <Trond.Myklebust@...app.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: netdev@...r.kernel.org
> Cc: linux-nfs@...r.kernel.org
> ---
> 
> No change from v2
> 
>  net/sunrpc/auth_gss/gss_krb5_wrap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sunrpc/auth_gss/gss_krb5_wrap.c b/net/sunrpc/auth_gss/gss_krb5_wrap.c
> index 88edec9..1da52d1 100644
> --- a/net/sunrpc/auth_gss/gss_krb5_wrap.c
> +++ b/net/sunrpc/auth_gss/gss_krb5_wrap.c
> @@ -130,8 +130,8 @@ gss_krb5_make_confounder(char *p, u32 conflen)
>  
>  	/* initialize to random value */
>  	if (i == 0) {
> -		i = random32();
> -		i = (i << 32) | random32();
> +		i = prandom_u32();
> +		i = (i << 32) | prandom_u32();
>  	}
>  
>  	switch (conflen) {

Acked-by: Trond Myklebust <Trond.Myklebust@...app.com>

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)