netdev - Re: Fw: [Bug 54601] New: PPP regression on 3.2.39 stop work need restart server ont version 3.2.21 not found this problem.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1362441915.15793.107.camel@edumazet-glaptop>
Date:	Mon, 04 Mar 2013 16:05:15 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	Stephen Hemminger <stephen@...workplumber.org>,
	netdev@...r.kernel.org, micron10@...il.com,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: Fw: [Bug 54601] New: PPP regression on 3.2.39 stop work need
 restart server ont version 3.2.21 not found this problem.

On Mon, 2013-03-04 at 22:48 +0000, Ben Hutchings wrote:
> On Fri, Mar 01, 2013 at 08:47:05AM -0800, Stephen Hemminger wrote:
> > 
> > 
> > Begin forwarded message:
> > 
> > Date: Fri, 1 Mar 2013 01:24:14 -0800
> > From: "bugzilla-daemon@...zilla.kernel.org" <bugzilla-daemon@...zilla.kernel.org>
> > To: "stephen@...workplumber.org" <stephen@...workplumber.org>
> > Subject: [Bug 54601] New: PPP regression on 3.2.39 stop work need restart server ont version 3.2.21 not found this problem.
> > 
> > 
> > https://bugzilla.kernel.org/show_bug.cgi?id=54601
> > 
> >            Summary: PPP regression on 3.2.39 stop work need restart server
> >                     ont version 3.2.21 not found this problem.
> >            Product: Networking
> >            Version: 2.5
> >     Kernel Version: 3.2.39
> >           Platform: All
> >         OS/Version: Linux
> >               Tree: Mainline
> >             Status: NEW
> >           Severity: high
> >           Priority: P1
> >          Component: Other
> >         AssignedTo: shemminger@...ux-foundation.org
> >         ReportedBy: micron10@...il.com
> >         Regression: Yes
> > 
> > 
> > Hi
> > watch a problem with PPP after upgrade to version 3.2.39 ppp service stop work
> > 2 hours after start with this crash :
> > 
> > [79619.180026] unregister_netdevice: waiting for ppp618 to become free. Usage
> > count = 562
> [...]
> > [79862.540040] unregister_netdevice: waiting for ppp618 to become free. Usage
> > count = 30
> > [79872.680037] unregister_netdevice: waiting for ppp618 to become free. Usage
> > count = 9
> [...]
> 
> So there are many references left to the device, which slowly go away
> (very slowly, about 2 per second).  Maybe there are skbs in a queue somewhere
> that still refer to the PPP device.
> 
> Since this a regression between 3.2.21 and 3.2.29, it might have been
> introduced by:
> 
> commit 73a3346556281fd56f39f0a9475249e5039d8807
> Author: Eric Dumazet <edumazet@...gle.com>
> Date:   Thu Jun 14 06:42:44 2012 +0000
> 
>     net: remove skb_orphan_try()
>     
>     commit 62b1a8ab9b3660bb820d8dfe23148ed6cda38574 upstream.
> 
> But this is a bit of a guess.  And I don't think that this change
> would do more than expose/exacerbate a bug that already existed.
> 
> Ben.
> 

I wonder which component could possibly take one dev refcnt for every
packet.

maybe xdst_queue_output in net/xfrm/xfrm_policy.c ?

Then maybe the cleanup is not properly done at device dismantle



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html