netdev - Re: [PATCH 1/1] net: ipv4: Remove redundant NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Mar 2013 08:45:32 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] net: ipv4: Remove redundant NULL check

On 6 March 2013 01:10, David Miller <davem@...emloft.net> wrote:
> From: Sachin Kamat <sachin.kamat@...aro.org>
> Date: Tue,  5 Mar 2013 16:57:09 +0530
>
>> kfree on a null pointer is a NO-OP. Hence null check is not necessary.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
>
> Unnecessary writes to the socket struct should be avoided, as it
> generates unnecessary write traffic to the L2 cache.

Sounds reasonable.

>
> I'm not applying this.

Ok. No problem.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html