netdev - Re: [PATCH] net/ipv4: Timestamp option cannot overflow with prespecified addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130305.235411.1636938131431522651.davem@davemloft.net>
Date:	Tue, 05 Mar 2013 23:54:11 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	david.ward@...mit.edu
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net/ipv4: Timestamp option cannot overflow with
 prespecified addresses

From: David Ward <david.ward@...mit.edu>
Date: Tue, 5 Mar 2013 22:06:32 -0500

> When a router forwards a packet that contains the IPv4 timestamp option,
> if there is no space left in the option for the router to add its own
> timestamp, then the router increments the Overflow value in the option.
> 
> However, if the addresses of the routers are prespecified in the option,
> then the overflow condition cannot happen: the option is structured so
> that each prespecified router has a place to write its timestamp. Other
> routers do not add a timestamp, so there will never be a lack of space.
> 
> This fix ensures that the Overflow value in the IPv4 timestamp option is
> not incremented when the addresses of the routers are prespecified, even
> if the Pointer value is greater than the Length value.
> 
> Signed-off-by: David Ward <david.ward@...mit.edu>

Applied, thanks for fixing this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html