netdev - Re: [PATCH] team: unsyc the devices addresses when port is removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130307183000.GA1532@minipsycho.orion>
Date:	Thu, 7 Mar 2013 19:30:00 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	Vlad Yasevich <vyasevic@...hat.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] team: unsyc the devices addresses when port is removed

Thu, Mar 07, 2013 at 06:59:25PM CET, vyasevic@...hat.com wrote:
>When a team port is removed, unsync all devices addresses that may have
>been synched to the port devices.


This is looking good to me. Thanks for spotting this bug.

Acked-by: Jiri Pirko <jiri@...nulli.us>

>
>CC: Jiri Pirko <jiri@...nulli.us>
>Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>
>---
> drivers/net/team/team.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
>index 05c5efe..bf34192 100644
>--- a/drivers/net/team/team.c
>+++ b/drivers/net/team/team.c
>@@ -1138,6 +1138,8 @@ static int team_port_del(struct team *team, struct net_device *port_dev)
> 	netdev_upper_dev_unlink(port_dev, dev);
> 	team_port_disable_netpoll(port);
> 	vlan_vids_del_by_dev(port_dev, dev);
>+	dev_uc_unsync(port_dev, dev);
>+	dev_mc_unsync(port_dev, dev);
> 	dev_close(port_dev);
> 	team_port_leave(team, port);
> 
>-- 
>1.7.7.6
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html