netdev - Re: [PATCH v2 0/7] USB: don't recover device if suspend fails in system sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130307.152807.2038557949816610391.davem@davemloft.net>
Date:	Thu, 07 Mar 2013 15:28:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ming.lei@...onical.com
Cc:	gregkh@...uxfoundation.org, jkosina@...e.cz,
	stern@...land.harvard.edu, oneukum@...e.de, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH v2 0/7] USB: don't recover device if suspend fails in
 system sleep

From: Ming Lei <ming.lei@...onical.com>
Date: Fri,  8 Mar 2013 00:15:17 +0800

> This patch adds comments on interface driver suspend callback
> to emphasize that the failure return value is ignored by
> USB core in system sleep context, so do not try to recover
> device for this case, otherwise the recovery things may confuse
> resume().
> 
> Also fixes the USB serial, HID and several usbnet drivers
> which may recover device in suspend failure path of system sleep.
> 
> v2:
> 	- improve comments on suspend callback as suggested by Alan
> 	- update kerneldoc for usb_suspend_both as suggested by Alan
> 	- remove previous check of PMSG_IS_AUTO(message) in cdc_mbim/
> 	qmi_wwan and add comments on suspend failure case, since Bjørn
> 	doesn't like the check.
> 	- add comments on smsc95xx/smsc75xx
> v1:
>         - fix compile failure
>         - add comments about handling suspend failure in resume()

Feel free to merge this via the USB tree and to add my ACK to the
networking driver bits:

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html