netdev - Re: [PATCH] netconsole: release the spinlock before __netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130307.161438.396456319050281566.davem@davemloft.net>
Date:	Thu, 07 Mar 2013 16:14:38 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	vfalico@...hat.com
Cc:	nhorman@...driver.com, netdev@...r.kernel.org, amwang@...hat.com
Subject: Re: [PATCH] netconsole: release the spinlock before
 __netpoll_cleanup()

From: Veaceslav Falico <vfalico@...hat.com>
Date: Thu, 7 Mar 2013 11:03:25 +0100

> @@ -680,9 +681,21 @@ static int netconsole_netdev_event(struct
> notifier_block *this,
>  				 * rtnl_lock already held
>  				 */
>  				if (nt->np.dev) {
> +					/*
> +					 * we still might sleep in
> + * __netpoll_cleanup(), so release
> +					 * the lock and restart

Quite a bit of email corruption of this patch.

Also, this code block is probably too deeply indented to be sane,
consider creating a small helper function to call instead.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html