netdev - Re: [PATCH] Fix: sparse warning in inet_csk_prepare_forced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130307.163154.1852978287105127033.davem@davemloft.net>
Date:	Thu, 07 Mar 2013 16:31:54 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	christoph.paasch@...ouvain.be
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Fix: sparse warning in inet_csk_prepare_forced_close

From: Christoph Paasch <christoph.paasch@...ouvain.be>
Date: Thu,  7 Mar 2013 13:34:33 +0100

> In e337e24d66 (inet: Fix kmemleak in tcp_v4/6_syn_recv_sock and
> dccp_v4/6_request_recv_sock) I introduced the function
> inet_csk_prepare_forced_close, which does a call to bh_unlock_sock().
> This produces a sparse-warning.
> 
> This patch adds the missing __releases.
> 
> Signed-off-by: Christoph Paasch <christoph.paasch@...ouvain.be>
> ---
>  net/ipv4/inet_connection_sock.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
> index 7d1874b..804c98f 100644
> --- a/net/ipv4/inet_connection_sock.c
> +++ b/net/ipv4/inet_connection_sock.c
> @@ -735,6 +735,7 @@ EXPORT_SYMBOL(inet_csk_destroy_sock);
>   * tcp/dccp_create_openreq_child().
>   */
>  void inet_csk_prepare_forced_close(struct sock *sk)
> +__releases(&sk->sk_lock.slock)

This should be indented by one TAB, I fixed this while applying your
patch, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html