netdev - Re: [PATCH] ipv6 addrconf: Fix addrconf_ifid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1362696088.2936.47.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Thu, 7 Mar 2013 22:41:28 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Alexander Aring <alex.aring@...il.com>
CC:	<davem@...emloft.net>, <kuznet@....inr.ac.ru>, <jmorris@...ei.org>,
	<yoshfuji@...ux-ipv6.org>,
	<linux-zigbee-devel@...ts.sourceforge.net>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH] ipv6 addrconf: Fix addrconf_ifid_eui64 of 802.15.4
 devices

On Thu, 2013-03-07 at 21:13 +0100, Alexander Aring wrote:
> The function addrconf_ifid_eui64 will copy eui into dev->dev_addr.
> We need first to manipulate eui[0] before we call memcpy afterwards.

memcpy() does not work that way.

> Broken since commit:
> 5e98a36ed4bf6ea396170e3af0dd4fcbe51d772f
> 
> Since this commit I got many trouble with the ieee802154 stack.

Your change is effectively reverting that commit.

Ben.

> Signed-off-by: Alexander Aring <alex.aring@...il.com>
> ---
>  net/ipv6/addrconf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index fa36a67..4460237 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -1731,8 +1731,8 @@ static int addrconf_ifid_eui64(u8 *eui, struct net_device *dev)
>  {
>  	if (dev->addr_len != IEEE802154_ADDR_LEN)
>  		return -1;
> -	memcpy(eui, dev->dev_addr, 8);
>  	eui[0] ^= 2;
> +	memcpy(eui, dev->dev_addr, 8);
>  	return 0;
>  }
>  

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html