netdev - Re: [RFC PATCH net-next 3/3] bridge: Implement IFF_UNICAST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51380542.4020601@gmail.com>
Date:	Wed, 06 Mar 2013 19:10:58 -0800
From:	John Fastabend <john.fastabend@...il.com>
To:	Vlad Yasevich <vyasevic@...hat.com>
CC:	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org
Subject: Re: [RFC PATCH net-next 3/3] bridge: Implement IFF_UNICAST_FLT

On 03/06/2013 06:31 PM, Vlad Yasevich wrote:
> Implement IFF_UNICAST_FLT on the bridge.  Unicast addresses added
> to the bridge device are synched to the uplink devices.  This
> allows for uplink devices to change while preserving mac assignment.
>
> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>
> ---

[...]

> diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
> index b0812c9..ef7b51e 100644
> --- a/net/bridge/br_fdb.c
> +++ b/net/bridge/br_fdb.c
> @@ -677,6 +677,9 @@ int br_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],
>   	struct net_port_vlans *pv;
>   	unsigned short vid = VLAN_N_VID;
>
> +	if ((ndm->ndm_flags & NTF_SELF) && (dev->priv_flags & IFF_EBRIDGE))
> +		return ndo_dflt_fdb_add(ndm, tb, dev, addr, nlh_flags);
> +
>   	if (!(ndm->ndm_state & (NUD_PERMANENT|NUD_NOARP|NUD_REACHABLE))) {
>   		pr_info("bridge: RTM_NEWNEIGH with invalid state %#x\n", ndm->ndm_state);
>   		return -EINVAL;
> @@ -774,6 +777,9 @@ int br_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[],
>   	struct net_port_vlans *pv;
>   	unsigned short vid = VLAN_N_VID;
>
> +	if ((ndm->ndm_flags & NTF_SELF) && (dev->priv_flags & IFF_EBRIDGE))
> +		return ndo_dflt_fdb_del(ndm, tb, dev, addr);
> +
>   	if (tb[NDA_VLAN]) {
>   		if (nla_len(tb[NDA_VLAN]) != sizeof(unsigned short)) {
>   			pr_info("bridge: RTM_NEWNEIGH with invalid vlan\n");
>

How is this different then calling the fdb op from rtnetlink.c when the
NTF_SELF bit is set after your previous patch

	net: generic fdb support for drivers without ndo_fdb_<op>

the generic routine gets called if a specific op is not supplied via
ndo ops anyways right?

Also I suspect if the driver supplies a specific ndo_fdb_<op> we should
use it over the generic one.

What am I missing?

Thanks,
John

-- 
John Fastabend         Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html