netdev - upgrade to 3.8.1 : BUG Scheduling while atomic in bonding driver:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <51385553.8060003@tlinx.org>
Date:	Thu, 07 Mar 2013 00:52:35 -0800
From:	Linda Walsh <lkml@...nx.org>
To:	LKML <linux-lkml@...r.kernel.org>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: upgrade to 3.8.1 : BUG Scheduling while atomic in bonding driver:




I am *not* seeing the bug in 3.8.2 with the 2nd patch applied (in
addition to the first)...


Michael Wang wrote:
>
>
> And both bond_enslave() and bond_mii_monitor() are using bond_update_speed_duplex()
> with preempt disabled.
>
> Along with the changes in bond_enslave(), I think you also need this (untested):
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 11d01d6..9af143a 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -2373,7 +2373,9 @@ static void bond_miimon_commit(struct bonding *bond)
>                                 bond_set_backup_slave(slave);
>                         }
>  
> +                       read_unlock(&bond->lock);
>                         bond_update_speed_duplex(slave);
> +                       read_lock(&bond->lock);
>  
>                         pr_info("%s: link status definitely up for interface %s, %u Mbps %s duplex.\n",
>                                 bond->dev->name, slave->dev->name,
>
>
> Regards,
> Michael Wang
>
>   
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html