netdev - Re: [PATCH] CAIF: fix indentation for function arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130306.193511.1262845535253279851.davem@davemloft.net>
Date:	Wed, 06 Mar 2013 19:35:11 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	silviupopescu1990@...il.com, netdev@...r.kernel.org,
	sjur.brandeland@...ricsson.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] CAIF: fix indentation for function arguments

From: Joe Perches <joe@...ches.com>
Date: Wed, 06 Mar 2013 16:07:17 -0800

> On Wed, 2013-03-06 at 23:48 +0200, Silviu-Mihai Popescu wrote:
>> This lines up function arguments on second and subsequent lines at the
>> first column after the openning parenthesis of the first line.
> []
>> diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c
> []
>> @@ -301,10 +301,10 @@ static void dev_flowctrl(struct net_device *dev, int on)
>>  }
>>  
>>  void caif_enroll_dev(struct net_device *dev, struct caif_dev_common *caifdev,
>> -			struct cflayer *link_support, int head_room,
>> -			struct cflayer **layer, int (**rcv_func)(
>> -				struct sk_buff *, struct net_device *,
>> -				struct packet_type *, struct net_device *))
>> +		     struct cflayer *link_support, int head_room,
>> +		     struct cflayer **layer, int (**rcv_func)(
>> +		     struct sk_buff *, struct net_device *,
>> +		     struct packet_type *, struct net_device *))
> 
> This makes it seem that caif_enroll_dev takes more args.
> 
> I think this style is better (aligned to appropriate open paren)
> 
> void caif_enroll_dev(struct net_device *dev, struct caif_dev_common *caifdev,
> 		     struct cflayer *link_support, int head_room,
> 		     struct cflayer **layer,
> 		     int (**rcv_func)(struct sk_buff *, struct net_device *,
> 				      struct packet_type *, struct net_device *))

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html