netdev - Re: hv_netvsc: WARNING in softirq.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACQ1gAi1NNwJ_QDp7ipjwdYCskENGN=N-j+TFD5aHX8DHnoBQA@mail.gmail.com>
Date:	Thu, 7 Mar 2013 11:12:19 +0100
From:	Richard Genoud <richard.genoud@...il.com>
To:	Haiyang Zhang <haiyangz@...rosoft.com>
Cc:	KY Srinivasan <kys@...rosoft.com>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: hv_netvsc: WARNING in softirq.c

2013/3/6 Haiyang Zhang <haiyangz@...rosoft.com>:
> I have found a simple way to reproduce this kind of warning:
> 1) reboot the VM (because this warning can be displayed only once.)
> 2) login to the host and open the VM [Settings]
> 3) Temporarily change the Network adapter's option [Virtual Switch] to "Not connected".
> 4) run dmesg, you should see the warning.
>
> The reason for the warning is -- netif_tx_disable() is called when the NIC
> is disconnected. And it's called within irq context. netif_tx_disable()
> calls local_bh_enable() which displays warning if in irq.
>
> The fix is to remove the unnecessary netif_tx_disable() in the netvsc_linkstatus_callback().
> I attached a patch. Would you like to test it on your side as well?
>
> Thanks,
> - Haiyang
>
Thanks for your reply.
I'll be able to test your patch in 2 or 3 weeks I guess (I haven't got
any access to the hyperV machine, the admin-sys is on holiday, and
it's a production server... So I don't want to mess with it right now
:) )

Regards,
Richard.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html