netdev - Re: [PATCH] iputils: fix memory leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <loom.20130307T121410-568@post.gmane.org>
Date:	Thu, 7 Mar 2013 11:18:21 +0000 (UTC)
From:	jb <jb.1234abcd@...il.com>
To:	netdev@...r.kernel.org
Subject: Re: [PATCH] iputils: fix memory leaks

David Laight <David.Laight <at> ACULAB.COM> writes:

> 
> >     Fix memory leaks
> ...
> > +#ifdef USE_IDN
> > +                               free(idn);
> > +                               idn = NULL;
> > +#endif
> >                                 exit(2);
> 
> There is no point calling free() before exit(), nor any need
> to free items that aren't allocated inside loops.
> 
> 	David

A matter of good style ? Overzealous ?
Flame ?
http://stackoverflow.com/questions/654754/what-really-happens-when-you-dont-free-after-malloc
jb



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html