netdev - Re: [PATCH] bgmac: register MII bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51387DDE.7040302@openwrt.org>
Date:	Thu, 07 Mar 2013 12:45:34 +0100
From:	Florian Fainelli <florian@...nwrt.org>
To:	Rafał Miłecki <zajec5@...il.com>
CC:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] bgmac: register MII bus

Hello Rafal,

On 03/07/2013 12:42 PM, Rafał Miłecki wrote:
>
> Signed-off-by: Rafał Miłecki <zajec5@...il.com>
> ---

This looking good, just one nitpick.

[snip]

> +
> +	mii_bus->irq = kmalloc(sizeof(int) * PHY_MAX_ADDR, GFP_KERNEL);

You can use kmalloc_array(PHY_MAX_ADDR, sizeof(int), GFP_KERNEL) here
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html