netdev - Re: [PATCH net-next] ipv6: ndisc: remove redundant check for !dev->addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <513A1279.3040105@linux-ipv6.org>
Date:	Sat, 09 Mar 2013 01:31:53 +0900
From:	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
To:	davem@...emloft.net
CC:	Thomas Graf <tgraf@...g.ch>, netdev@...r.kernel.org,
	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH net-next] ipv6: ndisc: remove redundant check for !dev->addr_len

Thomas Graf wrote:
> send_sllao is already initialized with the value of dev->addr_len
> 
> Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
> Signed-off-by: Thomas Graf <tgraf@...g.ch>
> ---
>  net/ipv6/ndisc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
> index 76ef435..2712ab2 100644
> --- a/net/ipv6/ndisc.c
> +++ b/net/ipv6/ndisc.c
> @@ -610,8 +610,6 @@ void ndisc_send_rs(struct net_device *dev, const struct in6_addr *saddr,
>  		}
>  	}
>  #endif
> -	if (!dev->addr_len)
> -		send_sllao = 0;
>  	if (send_sllao)
>  		optlen += ndisc_opt_addr_space(dev);
>  
> 
Acked-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html