netdev - Re: [PATCH net] tg3: Update link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130308.131542.1894554320106573944.davem@davemloft.net>
Date:	Fri, 08 Mar 2013 13:15:42 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	nsujir@...adcom.com
Cc:	netdev@...r.kernel.org, hirofumi@...l.parknet.co.jp,
	stable@...r.kernel.org, mchan@...adcom.com
Subject: Re: [PATCH net] tg3: Update link_up flag for phylib devices

From: "Nithin Nayak Sujir" <nsujir@...adcom.com>
Date: Fri, 8 Mar 2013 10:01:24 -0800

> Commit f4a46d1f46a8fece34edd2023e054072b02e110d introduced a bug where
> the ifconfig stats would remain 0 for phylib devices. This is due to
> tp->link_up flag never becoming true causing tg3_periodic_fetch_stats()
> to return.
> 
> The link_up flag was being updated in tg3_test_and_report_link_chg()
> after setting up the phy. This function however, is not called for
> phylib devices since the driver does not do the phy setup.
> 
> This patch moves the link_up flag update into the common
> tg3_link_report() function that gets called for phylib devices as well
> for non phylib devices when the link state changes.
> 
> To avoid updating link_up twice, we replace tg3_carrier_...() calls that
> are followed by tg3_link_report(), with netif_carrier_...(). We can then
> remove the unused tg3_carrier_on() function.
> 
> CC: <stable@...r.kernel.org>
> Reported-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
> Signed-off-by: Nithin Nayak Sujir <nsujir@...adcom.com>
> Signed-off-by: Michael Chan <mchan@...adcom.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html