netdev - Re: [PATCH net-next 1/4] net: Add skb_headers_offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130307214025.639c713c@nehalam.linuxnetplumber.net>
Date:	Thu, 7 Mar 2013 21:40:25 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Pravin B Shelar <pshelar@...ira.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, jesse@...ira.com
Subject: Re: [PATCH net-next 1/4] net: Add skb_headers_offset_update helper
 function.

On Thu,  7 Mar 2013 15:21:40 -0800
Pravin B Shelar <pshelar@...ira.com> wrote:

> +static void skb_headers_offset_update(struct sk_buff *skb, int off)
> +{
> +	/* {transport,network,mac}_header and tail are relative to skb->head */
> +	skb->transport_header += off;
> +	skb->network_header   += off;
> +	if (skb_mac_header_was_set(skb))
> +		skb->mac_header += off;
> +	skb->inner_transport_header += off;
> +	skb->inner_network_header += off;
> +}
> +

Won't this cause an unused function warning if NET_SKBUFF_DATA_USES_OFFSET is defined?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html