netdev - igb driver triggers BUILD_BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 9 Mar 2013 11:00:04 +0100
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Alexander Duyck <alexander.h.duyck@...el.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: igb driver triggers BUILD_BUG_ON on s390

git commit 74e238ead "igb: Support using build_skb in the case that
jumbo frames are disabled" added a BUILD_BUG_ON() to the igb drivers
which triggers on s390:

drivers/net/ethernet/intel/igb/igb_main.c:6231:2:
error: call to ‘__compiletime_assert_6235’ declared with attribute error:
  BUILD_BUG_ON failed: SKB_WITH_OVERHEAD(IGB_RX_BUFSZ) <
    (NET_SKB_PAD + NET_IP_ALIGN + IGB_TS_HDR_LEN + ETH_FRAME_LEN + ETH_FCS_LEN)

This happens mainly because s390 has an unusual large L1_CACHE_BYTES aka
SMP_CACHE_BYTES define with 256 Bytes.

The BUILD_BUG_ON(..) translates to (taken from .i file):

__cond = !(!(((2048) - (((sizeof(struct skb_shared_info)) + (256 - 1)) & ~(256 - 1))) < (32 + 2 + 16 + 1514 + 4)));

With sizeof(struct skb_shared_info) == 320 we end up with

BUILD_BUG_ON((2048 - 512 = 1536) < 1568)

One possible solution would be to simply disable the driver on s390.
Any opinions?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html