netdev - Re: [PATCH] eicon: Fixed checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130310.180218.753487547136940085.davem@davemloft.net>
Date:	Sun, 10 Mar 2013 18:02:18 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	andreea.cristina.hodea@...il.com
Cc:	mac@...ware.de, isdn@...ux-pingi.de, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, hodea_andreea@...oo.com
Subject: Re: [PATCH] eicon: Fixed checkpatch warning

From: David Miller <davem@...emloft.net>
Date: Sun, 10 Mar 2013 16:56:13 -0400 (EDT)

> From: Andreea Hodea <andreea.cristina.hodea@...il.com>
> Date: Sun, 10 Mar 2013 14:34:36 +0200
> 
>> drivers/isdn/hardware/eicon/diva_didd.c:32:6: warning: symbol
>> 'DRIVERRELEASE_DIDD' was not declared. Should it be static?
>> 
>> Signed-off-by: Andreea Hodea <hodea_andreea@...oo.com>
> 
> Applied, thanks.

I had to revert, did you even try to compile the driver after
this change?

The symbol is refenced by DbgRegister() calls in diddfunc.c, and
a very simple grep would have shown that to you.

Please do not just blindly try to fix checkpatch warnings.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html