netdev - RE: [PATCH -next] bnx2x: use list_move instead of list_del/list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6AE768456CEC4B4A9B2248CB6B87EB3E1BD109CC@SJEXCHMB05.corp.ad.broadcom.com>
Date:	Mon, 11 Mar 2013 16:53:30 +0000
From:	"Ariel Elior" <ariele@...adcom.com>
To:	"Wei Yongjun" <weiyj.lk@...il.com>,
	"Eilon Greenstein" <eilong@...adcom.com>
cc:	"yongjun_wei@...ndmicro.com.cn" <yongjun_wei@...ndmicro.com.cn>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [PATCH -next] bnx2x: use list_move instead of
 list_del/list_add

On Monday, March 11, 2013 4:40 PM Wei Yongjun wrote:
> Using list_move() instead of list_del() + list_add().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> index 71fcef0..c32a066 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> @@ -556,8 +556,7 @@ static int bnx2x_vfop_config_list(struct bnx2x *bp,
>  		rc = bnx2x_config_vlan_mac(bp, vlan_mac);
>  		if (rc >= 0) {
>  			cnt += pos->add ? 1 : -1;
> -			list_del(&pos->link);
> -			list_add(&pos->link, &rollback_list);
> +			list_move(&pos->link, &rollback_list);
>  			rc = 0;
>  		} else if (rc == -EEXIST) {
>  			rc = 0;
> 
> --

Thanks

Acked-by: Ariel Elior <ariele@...adcom.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html