netdev - Re: [net-next.git 4/9] stmmac: add the support for PTP hw clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130311185536.GA2409@netboy.at.omicron.at>
Date:	Mon, 11 Mar 2013 19:55:38 +0100
From:	Richard Cochran <richardcochran@...il.com>
To:	Rayagond K <rayagond@...avyalabs.com>
Cc:	Giuseppe CAVALLARO <peppe.cavallaro@...com>,
	netdev@...r.kernel.org, bh74.an@...sung.com
Subject: Re: [net-next.git 4/9] stmmac: add the support for PTP hw clock
 driver

On Sun, Mar 10, 2013 at 08:37:24PM +0530, Rayagond K wrote:
> On Sun, Mar 10, 2013 at 5:40 PM, Richard Cochran <richardcochran@...il.com>wrote:

> > Don't you need locking here to protect against concurrent callers of
> > config_addend?
> >
> 
> Yes we need locking here too, will add it.
> 
> But I can see no locking in this function in other two driver'e
> ppt_ixp46x.c and gianfar_ptp.c. So I just followed these two driver.

Those two drivers don't need locking, because setting the addend
register is a single 32 bit write operation in both cases.

In your driver, setting the addend involves a sequence of writes and
reads, in addition to polling a status bit, so you do need to
serialize access to those registers.

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html