netdev - Re: [PATCH] netconsole: don't call __netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Mar 2013 06:59:32 -0400 (EDT)
From:	David Miller <davem@...hat.com>
To:	nhorman@...driver.com
Cc:	vfalico@...hat.com, netdev@...r.kernel.org, amwang@...hat.com
Subject: Re: [PATCH] netconsole: don't call __netpoll_cleanup() while atomic

From: Neil Horman <nhorman@...driver.com>
Date: Mon, 11 Mar 2013 07:38:56 -0400

> On Mon, Mar 11, 2013 at 11:21:48AM +0100, Veaceslav Falico wrote:
>> __netpoll_cleanup() is called in netconsole_netdev_event() while holding a
>> spinlock. Release/acquire the spinlock before/after it and restart the
>> loop. Also, disable the netconsole completely, because we won't have chance
>> after the restart of the loop, and might end up in a situation where
>> nt->enabled == 1 and nt->np.dev == NULL.
>> 
>> Signed-off-by: Veaceslav Falico <vfalico@...hat.com>
 ...
> Acked-by: Neil Horman <nhorman@...driver.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html