netdev - Re: [PATCH net-next 05/22] cxgb4: Add T5 write combining support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <513F3EBD.5020504@opengridcomputing.com>
Date:	Tue, 12 Mar 2013 09:42:05 -0500
From:	Steve Wise <swise@...ngridcomputing.com>
To:	David Miller <davem@...emloft.net>
CC:	vipul@...lsio.com, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, linux-scsi@...r.kernel.org,
	roland@...estorage.com, JBottomley@...allels.com, dm@...lsio.com,
	leedom@...lsio.com, naresh@...lsio.com, divy@...lsio.com,
	santosh@...lsio.com, arvindb@...lsio.com, abhishek@...lsio.com
Subject: Re: [PATCH net-next 05/22] cxgb4: Add T5 write combining support

On 3/12/2013 7:19 AM, David Miller wrote:
> From: Vipul Pandya <vipul@...lsio.com>
> Date: Tue, 12 Mar 2013 17:16:17 +0530
>
>> +				writel(n,  adap->bar2 + q->udb + 8);
>> +#if defined(CONFIG_X86_32) || defined(CONFIG_X86_64)
>> +			asm volatile("sfence" : : : "memory");
>> +#endif
> There is absolutely no way I'm letting anyone put crap like this
> into a driver.
>
> Use a portable inteface, and if one does not exist create one.

I guess you'll have to add a wc_wmb() function for all the hw platforms 
supported by the kernel.  I see libibverbs defines this for the user 
side in include/infiniband/arch.h, and that could be used as the meat of 
the hw platform-specific implementations.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html