netdev - Re: [PATCH] ssb: pci: Fix flipping of MAC address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130313181817.GB19917@tuxdriver.com>
Date:	Wed, 13 Mar 2013 14:18:18 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	b43-dev@...ts.infradead.org, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org, zajec5@...il.com
Subject: Re: [PATCH] ssb: pci: Fix flipping of MAC address

On Mon, Mar 11, 2013 at 03:38:26PM -0500, Larry Finger wrote:
> Since commit e565275 entitled "ssb: pci: Standardize a function to get mac
> address", the SPROM readout of the MAC has had the values flipped so that
> 00:11:22:33:44:55 became 11:00:33:22:55:44. The fix has been tested on both
> little- and big-endian architectures.
> 
> Reported-by: Rafał Miłecki <zajec5@...il.com>
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
> ---
> 
> John,
> 
> This bug was introduced in 3.9, and should be fixed there.
> 
> Thanks,
> 
> Larry
> ---
> 
> Index: wireless-testing-new/drivers/ssb/pci.c
> ===================================================================
> --- wireless-testing-new.orig/drivers/ssb/pci.c
> +++ wireless-testing-new/drivers/ssb/pci.c
> @@ -234,8 +234,8 @@ static void sprom_get_mac(char *mac, con
>  {
>  	int i;
>  	for (i = 0; i < 3; i++) {
> -		*mac++ = in[i];
>  		*mac++ = in[i] >> 8;
> +		*mac++ = in[i];
>  	}
>  }

Actually, FWIW it seems to have been introduced in commit
e5652756ff36ed9e1283121f788e6a17117efcab, which is slated for 3.10.
I'm happy to merge it in wireless-next.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html