netdev - Re: [PATCH net-next 05/22] cxgb4: Add T5 write combining support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <514103B5.7040002@chelsio.com>
Date:	Wed, 13 Mar 2013 15:54:45 -0700
From:	Casey Leedom <leedom@...lsio.com>
To:	David Laight <David.Laight@...LAB.COM>
CC:	Vipul Pandya <vipul@...lsio.com>,
	Steve Wise <swise@...ngridcomputing.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, linux-scsi@...r.kernel.org,
	roland@...estorage.com, JBottomley@...allels.com,
	Dimitrios Michailidis <dm@...lsio.com>,
	Naresh Kumar Inna <naresh@...lsio.com>,
	Divy Le Ray <divy@...lsio.com>,
	Santosh Rastapur <santosh@...lsio.com>,
	Arvind Bhushan <arvindb@...lsio.com>,
	Abhishek Agrawal <abhishek@...lsio.com>
Subject: Re: [PATCH net-next 05/22] cxgb4: Add T5 write combining support

On 03/13/13 08:43, David Laight wrote:
> From my recollection of the x86 architecture, the memory barriers are 
> hardly ever needed, certainly not in the places where, for example a 
> ppc needs them. I'd actually suspect that the normal wmb() for x86 
> should be a nop. About the only place where any on the fence 
> instructions are needed are in relation to write combining accesses. 
> In particular I don't believe they are ever needed to synchronise 
> uncached accesses with each other, or with cached accesses (which are 
> snooped). David 

   The question at hand is how should we indicate that we're finished 
with a Write Combined set of stores in an architecturally neutral 
manner?  Is wmb() a good approach?  Vipul has noted that the iWarp code 
uses a new "wc_wmb()" for this purpose which seems to be the same 
_currently_ as wmb() for all current platforms.  I presume that the 
iWarp folks pick a new name to offer themselves some cover in the future.

   And yes, the code sequence that was accidentally included in Vipul's 
previous patches should never have been submitted for inclusion in 
kernel.org.  It got missed in our internal reviews and I apologize for that.

Casey
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html