netdev - Re: [PATCH net-next 1/4] bridge: Add sysfs interface to control promisc mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51409ED9.5080304@redhat.com>
Date:	Wed, 13 Mar 2013 11:44:25 -0400
From:	Vlad Yasevich <vyasevic@...hat.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next 1/4] bridge: Add sysfs interface to control promisc
 mode

On 03/13/2013 11:38 AM, Stephen Hemminger wrote:
> On Tue, 12 Mar 2013 21:45:23 -0400
> Vlad Yasevich <vyasevic@...hat.com> wrote:
>
>> Add an sysfs interface to turn promiscusous mode on and off on
>> the bridge.  By default all interfaces in the bridge
>> are in promisc mode.  When promisc mode is turned off, it is
>> turned off on all bridge ports and the bridge turns on IFF_ALLMULTI
>> to handle multicast traffic.
>>
>> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>
>> ---
>>   net/bridge/br_device.c   |   41 +++++++++++++++++++++++++++++++++++++++++
>>   net/bridge/br_if.c       |   22 +++++++++++++++++-----
>>   net/bridge/br_private.h  |    2 ++
>>   net/bridge/br_sysfs_br.c |   17 +++++++++++++++++
>>   4 files changed, 77 insertions(+), 5 deletions(-)
>>
>
> All attribute changes must also be available through netlink, and changes
> to attributes should cause a notification to applications listening for
> netlink events on that bridge.
>

There is currently no attribute for promisc vs non-promisc in the 
bridge.  Are you suggesting that this patch should add one?

-vlad
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html