netdev - Re: [PATCH 1/1] Fix dst_neigh_lookup/dst_neigh_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAABZP2ymK4nrAG6AN2rjxnJ0fiXQh7sUS0SLA=g0LxRVuBmHRQ@mail.gmail.com>
Date:	Thu, 14 Mar 2013 13:48:58 +0800
From:	Zhouyi Zhou <zhouzhouyi@...il.com>
To:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] Fix dst_neigh_lookup/dst_neigh_lookup_skb return
 value handling bug

Cong Wang <xiyou.wangcong@...il.com>  wrote
>>  	neigh = dst_neigh_lookup(ep->dst,
>>  			&ep->com.cm_id->remote_addr.sin_addr.s_addr);
>> +	if (!neigh) {
>> +		pr_err("%s - cannot alloc neigh.\n", __func__);
>> +		err = -ENOMEM;
>> +		goto fail4;

>You don't need to print error messages for OOM, the mm subsystem will
>do.
Thanks for reviewing,  I clone these error messages print from the code
that follows:
   1612         if (!ep->l2t) {
   1613                 pr_err("%s - cannot alloc l2e.\n", __func__);
   1614                 err = -ENOMEM;
   1615                 goto fail4;
   1616         }
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html