netdev - Re: [PATCH net-next 1/6] GRE: Use RTNL for atomic protocol registration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALnjE+oJKL5EwaEhbScyfVZtcfXNS_BqJdnA2+f6OXtkPz7aDg@mail.gmail.com>
Date:	Thu, 14 Mar 2013 20:37:16 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Michał Mirosław <mirqus@...il.com>
Cc:	davem@...emloft.net, stephen@...workplumber.org,
	netdev@...r.kernel.org, jesse@...ira.com
Subject: Re: [PATCH net-next 1/6] GRE: Use RTNL for atomic protocol registration.

On Wed, Mar 13, 2013 at 4:22 PM, Michał Mirosław <mirqus@...il.com> wrote:
> 2013/3/13 Pravin B Shelar <pshelar@...ira.com>:
>> Currently gre demultiplexer uses its own spin-lock. We should
>> rather RTNL lock.
> [...]
>> +       rtnl_lock();
>>         err = gre_add_protocol(&gre_pptp_protocol, GREPROTO_PPTP);
>> +       rtnl_unlock();
>
> Why not keep lock/unlock inside gre_add/del_protocol()?
>
As Stephen suggested I am planning on dropping this patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html