netdev - Re: [PATCH] phy: Elimination the forced speed reduction algorithm.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130315.085135.1979138622322564611.davem@davemloft.net>
Date:	Fri, 15 Mar 2013 08:51:35 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	kapranoff@...ox.ru, netdev@...r.kernel.org,
	bhutchings@...arflare.com, peppe.cavallaro@...com,
	bruce.w.allan@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: Elimination the forced speed reduction algorithm.

From: Joe Perches <joe@...ches.com>
Date: Fri, 15 Mar 2013 05:48:49 -0700

> The phy code also uses non standard kernel style tests like
> 	if (CONSTANT == variable)
> instead of
> 	if (variable == CONSTANT)

Right, to trigger compile time errors when "=" is accidently used
instead of "==".

But the whole driver is like this already.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html