netdev - RE: [PATCH net] bnx2x: add missing napi deletion in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <504C9EFCA2D0054393414C9CB605C37F20BE36EA@SJEXCHMB06.corp.ad.broadcom.com>
Date:	Sat, 16 Mar 2013 08:18:35 +0000
From:	"Dmitry Kravkov" <dmitry@...adcom.com>
To:	"Michal Schmidt" <mschmidt@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
cc:	"Merav Sicron" <meravs@...adcom.com>,
	"Eilon Greenstein" <eilong@...adcom.com>,
	"Yuval Mintz" <yuvalmin@...adcom.com>
Subject: RE: [PATCH net] bnx2x: add missing napi deletion in error path

> -----Original Message-----
> From: Michal Schmidt [mailto:mschmidt@...hat.com]
> Sent: Friday, March 15, 2013 5:28 PM
> To: netdev@...r.kernel.org
> Cc: Merav Sicron; Eilon Greenstein; Dmitry Kravkov; Yuval Mintz
> Subject: [PATCH net] bnx2x: add missing napi deletion in error path
> 
> If the hardware initialization fails in bnx2x_nic_load() after adding
> napi objects, they would not be deleted. A subsequent attempt to unload
> the bnx2x module detects a corruption in the napi list.
> 
> Add the missing napi deletion to the error path.
> 
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> index a923bc4..4046f97 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> @@ -2760,6 +2760,7 @@ load_error2:
>  	bp->port.pmf = 0;
>  load_error1:
>  	bnx2x_napi_disable(bp);
> +	bnx2x_del_all_napi(bp);
> 
>  	/* clear pf_load status, as it was already set */
>  	if (IS_PF(bp))
> --
> 1.8.1.4
>
Thanks, Michal!

Acked-by: Dmitry Kravkov <dmitry@...adcom.com>
 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html