netdev - RE: [PATCH] bnx2x: fix occasional statistics off-by-4GB error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <504C9EFCA2D0054393414C9CB605C37F20BE6A2B@SJEXCHMB06.corp.ad.broadcom.com>
Date:	Sun, 17 Mar 2013 13:10:37 +0000
From:	"Dmitry Kravkov" <dmitry@...adcom.com>
To:	Maciej Żenczykowski <zenczykowski@...il.com>,
	Maciej Żenczykowski <maze@...gle.com>,
	"David S. Miller" <davem@...emloft.net>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Yuval Mintz" <yuvalmin@...adcom.com>
Subject: RE: [PATCH] bnx2x: fix occasional statistics off-by-4GB error

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] On Behalf Of Maciej ?enczykowski
> Sent: Friday, March 15, 2013 11:56 PM
> To: Maciej Żenczykowski; David S. Miller
> Cc: netdev@...r.kernel.org; Yuval Mintz
> Subject: [PATCH] bnx2x: fix occasional statistics off-by-4GB error
> 
> From: Maciej Żenczykowski <maze@...gle.com>
> 
> The UPDATE_QSTAT function introduced on February 15, 2012
> in commit 1355b704b9ba "bnx2x: consistent statistics after
> internal driver reload" incorrectly fails to handle overflow
> during addition of the lower 32-bit field of a stat.
> 
> This bug is present since 3.4-rc1 and should thus be considered
> a candidate for stable 3.4+ releases.
> 
> Google-Bug-Id: 8374428
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>
> Cc: Mintz Yuval <yuvalmin@...adcom.com>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.h
> index 364e37ecbc5c..198f6f1c9ad5 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.h
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.h
> @@ -459,8 +459,9 @@ struct bnx2x_fw_port_stats_old {
> 
>  #define UPDATE_QSTAT(s, t) \
>  	do { \
> -		qstats->t##_hi = qstats_old->t##_hi + le32_to_cpu(s.hi); \
>  		qstats->t##_lo = qstats_old->t##_lo + le32_to_cpu(s.lo); \
> +		qstats->t##_hi = qstats_old->t##_hi + le32_to_cpu(s.hi) \
> +			+ ((qstats->t##_lo < qstats_old->t##_lo) ? 1 : 0); \
>  	} while (0)
> 
>  #define UPDATE_QSTAT_OLD(f) \
> --
> 1.8.1.3
> 

Probably this commit resolved the issue:

commit bef05406ac0ea6f468e1e25e9934f3011ea9259b
Author: Dmitry Kravkov <dmitry@...adcom.com>
Date:   Tue Sep 11 04:34:08 2012 +0000

    bnx2x: Avoid sending multiple statistics queries

Can you try it pls?

Thanks