netdev - Re: [Bug 55211] pci_disable_link_state PCIE_LINK_STATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQXmeb66dc8fET0y99BjqpUXp11c7utiQ5keR1Wf+N9xaA@mail.gmail.com>
Date:	Sun, 17 Mar 2013 10:19:40 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	bugzilla-daemon@...zilla.kernel.org,
	Roman Yepishev <roman.yepishev@...il.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Taku Izumi <izumi.taku@...fujitsu.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-pci@...r.kernel.org, NetDev <netdev@...r.kernel.org>
Subject: Re: [Bug 55211] pci_disable_link_state PCIE_LINK_STATE_L0S no longer
 disables ASPM for ath5k

On Sun, Mar 17, 2013 at 8:50 AM,  <bugzilla-daemon@...zilla.kernel.org> wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=55211

> --- Comment #9 from Roman Yepishev <roman.yepishev@...il.com>  2013-03-17 15:50:23 ---
> Re-tested on two laptops - AOA150, ath5k device got ASPM disabled and on a
> Lenovo E420 I got ASPM disabled for iwlwifi-driven Intel Corporation Centrino
> Wireless-N 1000 [8086:0084].
>
> Also I found http://article.gmane.org/gmane.linux.kernel.pci/20640 where a
> question was raised why pci_disable_link_state stopped doing anything for
> iwlwifi devices too.
>

good.

Did you test first patch or second patch?

Please test second patch only on affected platforms.

old logic is quite strange, on boot path and hotplug path it have
different aspm_disabled setting.
as it could set aspm_disabled after pci root bus scanning.

Second patch will not restore to old logic, and just remove not needed
aspm_disabled checking
for disabling path.

So second patch is right fix, but it need more test.

Thanks

Yinghai

Download attachment "pci_acpi_osc_aspm_fix.patch" of type "application/octet-stream" (3533 bytes)

Download attachment "disable_aspm_remove_not_needed_check.patch" of type "application/octet-stream" (3040 bytes)