netdev - Re: [PATCH net] vhost/net: fix heads usage of ubuf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130317.142955.1114572401286297685.davem@davemloft.net>
Date:	Sun, 17 Mar 2013 14:29:55 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mst@...hat.com
Cc:	stable@...nel.org, rusty@...tcorp.com.au, jasowang@...hat.com,
	basil.gor@...il.com, nab@...ingtidesystems.com,
	kvm@...r.kernel.org, virtualization@...ts.linux-foundation.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] vhost/net: fix heads usage of ubuf_info

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Sun, 17 Mar 2013 14:46:09 +0200

> ubuf info allocator uses guest controlled head as an index,
> so a malicious guest could put the same head entry in the ring twice,
> and we will get two callbacks on the same value.
> To fix use upend_idx which is guaranteed to be unique.
> 
> Reported-by: Rusty Russell <rusty@...tcorp.com.au>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>

Applied and queued up for -stable, thanks.

And thankfully you got the stable URL wrong, please do not CC:
networking patches to stable, just make sure I apply them and in
your post-commit text explicitly ask me to queue it up to my
-stable queue.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html