netdev - Re: [PATCHv3 vringh] caif_virtio: Introduce caif over virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ip4ps74v.fsf@rustcorp.com.au>
Date:	Mon, 18 Mar 2013 14:15:36 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Ohad Ben-Cohen <ohad@...ery.com>,
	Erwan Yvin <erwan.yvin@...ricsson.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Rusty Russel <rusty@...corp.com.au>,
	Sjur Braendeland <sjur.brandeland@...ricsson.com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	virtualization <virtualization@...ts.linux-foundation.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCHv3 vringh] caif_virtio: Introduce caif over virtio

Ohad Ben-Cohen <ohad@...ery.com> writes:
> Hi Erwan,
>
> On Fri, Mar 15, 2013 at 11:42 AM, Erwan Yvin <erwan.yvin@...ricsson.com> wrote:
>> +++ b/drivers/net/caif/caif_virtio.c
...
>> +#include <linux/remoteproc.h>
>
> The driver looks nicely decoupled from remoteproc - do you still need
> remoteproc.h ?

Seems not.

Thanks,
Rusty.

caif_virtio: remove unneeded remoteproc.h

Reported-by: Ohad Ben-Cohen <ohad@...ery.com>
Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>

diff --git a/drivers/net/caif/caif_virtio.c b/drivers/net/caif/caif_virtio.c
index 6a745dd..b1e1205 100644
--- a/drivers/net/caif/caif_virtio.c
+++ b/drivers/net/caif/caif_virtio.c
@@ -15,7 +15,6 @@
 #include <linux/interrupt.h>
 #include <linux/netdevice.h>
 #include <linux/rtnetlink.h>
-#include <linux/remoteproc.h>
 #include <linux/virtio_ids.h>
 #include <linux/virtio_caif.h>
 #include <linux/virtio_ring.h>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html