netdev - Re: [PATCH v2 net-next 1/4] flow_keys: include thoff into flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51487ED9.5000200@redhat.com>
Date:	Tue, 19 Mar 2013 16:06:01 +0100
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	netdev@...r.kernel.org, davem@...emloft.net, jasowang@...hat.com
Subject: Re: [PATCH v2 net-next 1/4] flow_keys: include thoff into flow_keys
 for later usage

On 03/19/2013 04:03 PM, Eric Dumazet wrote:
> On Tue, 2013-03-19 at 15:34 +0100, Daniel Borkmann wrote:
>> In skb_flow_dissect(), we perform a dissection of a skbuff. Since we're
>> doing the work here anyway, also store thoff for a later usage, e.g. in
>> the BPF filter. Also, by having thoff 16 Bit, we do not need to pack
>> flow_keys and reorder choke_skb_cb.
>>
>> Suggested-by: Eric Dumazet <edumazet@...gle.com>
>> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>
>> ---
>>   This patch also needs to go into the net tree, since Eric or Jason will
>>   post a bug fix on top of this one.
>>
>>   include/net/flow_keys.h   | 1 +
>>   net/core/flow_dissector.c | 5 ++++-
>>   2 files changed, 5 insertions(+), 1 deletion(-)
>
> Oh well, you left the choke_skb_cb description in changelog

But it's not the old changelog. ;-)

  Also, by having thoff 16 Bit, we do *not* need to pack flow_keys and
  reorder choke_skb_cb.

> Acked-by: Eric Dumazet <edumazet@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html