netdev - Re: [PATCH v2 net-next 1/5] GRE: Refactor GRE tunneling code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130319135828.0dd18d40@nehalam.linuxnetplumber.net>
Date:	Tue, 19 Mar 2013 13:58:28 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Bjørn Mork <bjorn@...k.no>
Cc:	David Miller <davem@...emloft.net>, pshelar@...ira.com,
	netdev@...r.kernel.org, jesse@...ira.com
Subject: Re: [PATCH v2 net-next 1/5] GRE: Refactor GRE tunneling code.

On Tue, 19 Mar 2013 11:31:30 +0100
Bjørn Mork <bjorn@...k.no> wrote:

> David Miller <davem@...emloft.net> writes:
> > From: Stephen Hemminger <stephen@...workplumber.org>
> >> On Mon, 18 Mar 2013 11:13:25 -0700
> >> Pravin B Shelar <pshelar@...ira.com> wrote:
> >> 
> >>> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> >>> index 7944df7..2073226 100644
> >>> --- a/net/ipv4/Kconfig
> >>> +++ b/net/ipv4/Kconfig
> >>> @@ -186,9 +186,14 @@ config NET_IPGRE_DEMUX
> >>>  	 This is helper module to demultiplex GRE packets on GRE version field criteria.
> >>>  	 Required by ip_gre and pptp modules.
> >>>  
> >>> +config NET_IP_TUNNEL
> >>> +	tristate
> >>> +	default n
> >>> +
> >> 
> >> Won't this break existing kernel config's, shouldn't this default y?
> >
> > Or "m".  But indeed, it should be made to automatically work for
> > existing configs.
> 
> Won't the "select NET_IP_TUNNEL" statements do just that?
> 
> Changing the default to m will enable this module even if all of
> NET_IPGRE, VXLAN and NET_IPIP are disabled. That's pointless, isn't it?

Looks like you are right, just tried a number of different kernel
configs with 'make oldconfig' and it picks up the dependency  correctly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html