netdev - Re: [PATCH net-next v3] packet: packet fanout rollover during socket overload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Mar 2013 17:34:40 -0400
From:	Willem de Bruijn <willemb@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3] packet: packet fanout rollover during socket overload

On Tue, Mar 19, 2013 at 5:16 PM, David Miller <davem@...emloft.net> wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Tue, 19 Mar 2013 13:37:17 -0700
>
>> On Tue, 2013-03-19 at 16:18 -0400, Willem de Bruijn wrote:
>>> Changes:
>>>   v3->v2: rebase (no other changes)
>>>           passes selftest
>>>   v2->v1: read f->num_members only once
>>>           fix bug: test rollover mode + flag
>  ...
>>> Signed-off-by: Willem de Bruijn <willemb@...gle.com>
>  ...
>> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
>
> Applied, and I added the selftest too

Thanks!

>, but it fails for me on my
> 128-cpu sparc64 machine:
>
> make[1]: Entering directory `/home/davem/src/GIT/net-next/tools/testing/selftests/net-afpacket'
> --------------------
> running psock_fanout test
> --------------------
> test: control single socket
> test: control multiple sockets
> test: datapath 0x0
> info: count=0,0, expect=0,0
> info: count=0,20, expect=15,5
> ERROR: incorrect queue lengths

I'm looking into it. The test needs the packet sockets to be able to
hold an exact number of test packets and then overflow. Queue
length configured in bytes (SO_RCVBUF) was arrived at by
experimentation. My best hunch so far is that this differs between
platforms/nic, if skb->truesize does. If queue length is the problem,
I'll switch to a packet ring. Booting another machine right now.

> [FAIL]
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html