netdev - Re: [PATCH net-next] packet: Fix compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130319.180722.1735800542274116990.davem@davemloft.net>
Date:	Tue, 19 Mar 2013 18:07:22 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dbaluta@...acom.com
Cc:	willemb@...gle.com, edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] packet: Fix compile error

From: Daniel Baluta <dbaluta@...acom.com>
Date: Wed, 20 Mar 2013 00:01:21 +0200

> PACKET_FANOUT_ROLLOVER and PACKET_FANOUT_FLAG_ROLLOVER are not declared in
> <tree>/usr/include/linux/if_packet.h together with the other PACKET_FANOUT_* macros
> as one would expect. This causes the following compilation error:
> <snip>
> psock_fanout.c: In function ‘test_control_single’:
> psock_fanout.c:230:23: error: ‘PACKET_FANOUT_ROLLOVER’ undeclared (first use in this function)
> </snip>
> 
> Signed-off-by: Daniel Baluta <dbaluta@...acom.com>

No, in fact, all of these should be removed completely.

They are provided by the header files under linux/usr/include which
get created by the "make headers_install" rule.

So you either need to run the "make headers_install" rule before
building the tests, or install the updated headers under /usr/include
on your test machine.

I'll remove the defines from the test, thanks for pointing this
out.